i guess that means the backup sw doesnt do samba shares ?

nope - i just don't know enough about where docker is going to decide if we should add vbox or not

given that brad is implementing something in the docker client

and that using -v /host:/container isn't portable

if I could set up a container that was a samba client, and declare the cifs mount point as a volue that would help too

but atm, the shared volume creats a new volume and so the dofs mount is lost

mostly, because -v bindmount is frowned upon, i look for solutions that assume it doesn't exist.

maybe

we don't have top level volume management and it's too easy to delete a non running data container

agreed - volumes need more lovin

crosbymichael: why did you switched from github handle to emails in pulls

?

[boot2docker] SvenDowideit opened pull request #330: We need active maintainers (master...maintainers-update) http://git.io/B2doVA

vieux: shykes_ thought it is better because some ppl may not have a github account

ok crosbymichael I've added a PR to make you a maintainer for both b2d and b2d-cli

crosbymichael: looks like I have to rebase anyway. have you merged your stuff yet? (just to know if I should start rebasing now, or wait until you've merged yours)

yes

it's merged but shouldn't conflict

i didn't touch mount stuff

I ended up touching more stuff 🙂

let's see if that's trivial rebase or what.

thanks!

crosbymichael: vieux : I just meant "let's not crash if the github handle is not specified", reall

*really

ok

🙂

but if github handle is going to be optional, then yeah it makes more sense to display the part that is not optional

I'm fine with it, it's just that my --maintainer pr take an email as argument

i like the emails better anyways

ah

vieux: we could have the filter match either one

yes but it was removed from the reviewer.go code completly crosbymichael ^

whattttt

crosbymichael: https://github.com/dotcloud/gordon/commit/e45cb...

vieux: crosbymichael did you get to test that 'pulls send' branch?

I just need to know if 'pulls send' without argument works

where is the code to test?

[docker] vieux created pr_out_pull_send_opens_a_new_pr_from_the_current_branch from master (+0 new commits): http://git.io/ymQpkQ

oups ^

🙂

ahhh

no no

my mistake

git fetch https://github.com/shykes/gordon pr_out_pull_send_opens_a_new_pr_from_the_current_branch && git checkout FETCH_HEAD

(I used 'pulls send' to send the pull request implement 'pulls send')

ok nevermind I found the bug

crosbymichael: I updated #gh5445. I still need help with tests but it's getting there (and let me know if it should be reshaped in any way. I'm getting more familiar with that part of the code so it won't be a big deal)

Mount /proc and /sys read-only, except in privileged containers.: https://github.com/dotcloud/docker/pull/5445

are your changes pushed ?

yup, looks like it

[docker] vbatts opened pull request #5514: docker save: typo reference image, not container (master...vbatts-save_typo) http://git.io/Wis1dg

[docker] crosbymichael opened pull request #5515: Remove CommandFactory and NsInit interface (master...refactor-libcontainer2) http://git.io/5y2x5g

boom!

[docker] vieux closed pull request #5514: docker save: typo reference image, not container (master...vbatts-save_typo) https://github.com/dotcloud/docker/pull/5514

[docker] SvenDowideit opened pull request #5516: add page_description and page_keywords md meta to mkdocs html template (master...docs-meta-rendering) http://git.io/wf8ZBw