#amara

/

      • deaner1 has quit
      • deaner joined the channel
      • deaner1 joined the channel
      • deaner has quit
      • deaner1 has quit
      • willkg has quit
      • janeted joined the channel
      • janeted
        Hi maggie_s
      • maggie_s
        hi jan
      • hi janeted
      • janeted
        didn't notice any new tickets, did you get a chance to try 1322 and 1323?
      • maggie_s
        janeted: I am at 1322 right now
      • janeted
        bulk approvals
      • sylvainc joined the channel
      • I didn't explain it at all, but basically if the tasks are less than 3 weeks old they are grey - just to give a visual
      • but still selectable
      • sylvainc
        morning janeted, just saw your comments about taks and gray color, is it from this morning?
      • janeted
        maggie_s, is doing a little testing on 1323 and 1322 too.
      • so I was just explaining a bit.
      • sylvainc
        ok, good, thanks, was fearing i misunderstood that feature
      • janeted
        no - I think eventually we'll want to add the filters - but this is good to start
      • sylvainc
        good
      • janeted
        I made the pull requests - but I think it's good to have ben review them. I chatted with Dean last night -and he agreed that it's better to do our usual process and not just rush
      • sylvainc
        sure, they are both big with some tricky things inside
      • janeted
        I think we'll be able to get them out today feeling good about the changes
      • maggie_s, what do you think so far?
      • maggie_s
        janeted: the list of tasks includes Assignee field, but approval tasks that are already assigned to anyone are not included - is that intentional?
      • janeted
        I'd asked for that field not realizing we were going to only include unassigned.
      • I don't think it matters too much
      • maggie_s
        so listing only unassigned ones is the desired behaviour
      • janeted
        yes - i don't think we want to be yanking away tasks that someone may be working on.
      • I think if they start using it and want a few tweak - then we can make changes
      • maggie_s
        janeted: generally looks good to me. If I am to nitpick, I'd mention that: 1) language codes are not very human friendly, and names would do better here; 2) gray area is not very self-explanatory, so a short legend above the table would be helpful; 3) when there are no projects in teams, the field's value is set to "--------" which spills over to the next line; "None" would do better; 4) when you select all and then start deselecting
      • , Select All remains checked - not a big deal, but different from the usual behavior for bulk selectors
      • of all the above, 1) and 2) look more important to me
      • janeted
        thanks maggie_s all good points. we were rushed on this so UI took a backseat but these all seem do-able. sylvainc what do you think.
      • sylvainc
        I agree these are all good points,
      • the gray area might become less relevant once we have filtering
      • and I'd suggest to put all these in one or a few tickets
      • maggie_s
        sylvainc: 1322 or new ones?
      • sylvainc
        actually 1, 2 and 3 are really simple, we could keep it in 1322
      • maggie_s
        sylvainc: ok
      • sylvainc
        For 4, I'd prefer to do it on another ticket. 1322 and 1323 are already really big
      • janeted
        sylvainc, maybe we should put a heading at the top of the page something like
      • Bulk Accept Approval Tasks - so it's clear what the page is for, then the legend text below.
      • white tasks are haven't been modified in more than 3 weeks (or similar)
      • sylvainc
        janeted: should these go inside the tab?
      • janeted
        yeah - on the actual approvals page.
      • ben did this on the feeds page:
      • we could do something similar
      • sylvainc
        ok, got it
      • maggie_s has quit
      • willkg joined the channel
      • janeted
        sylvainc, for the 1322 helper text, can you just put a period at the end of the sentence, and perhaps italicize the who sentence?
      • sylvainc
        sure, you mean make "White tasks haven't been modified in more than 3 weeks" italic?
      • janeted
        and maybe it should say, Tasks in white rows haven't ....
      • yes.
      • sylvainc
        yep, doing it right now so I wont forget
      • janeted
        htanks
      • deaner joined the channel
      • sylvainc, are you in the 1322 branch now?
      • sylvainc
        yes, I am on the None vs. ----- issue for project display
      • janeted
        ok - what if we took out the Assignee row, since as margarita pointed out it's always None, then have a wider projects row.
      • sylvainc
        ok, sure, you mean column, right?
      • janeted
        and add the word unassigned to the title - so it reads 'Bulk Accept Unassigned Approval Tasks
      • (yes meant column)
      • sylvainc
        yes, sounds good
      • janeted
        I think that would make it super clear
      • sylvainc
        agree
      • alex_dn has left the channel
      • janeted: just moved to 1323, the first item is about a title for the page, is it for a page title in the browser title, or a title inside the tab? Or both?
      • janeted
        I think a page title like 1322
      • also - on 1322 - looks like something went awry with the main tasks page layout
      • sylvainc
        argh, sorry, more css pbs
      • So the "tell us which lanaguage...."
      • would be the title of the tab?
      • janeted
        no I'm confused. about the titile
      • this is for move videos, right?
      • sylvainc
        yes
      • i just saw the one in your screenshot
      • janeted
        I assumed she was just referring to a heading like what you added to the bulk approval page.
      • in the screenshot - I meant to show you where the body of the task is push downwards
      • Approve Original ... should align with the thumb
      • sylvainc
        ok, sorry, just do mechanically
      • any idea of the title?
      • just Move Videos?
      • janeted
        yes that's fine
      • sylvainc
        ok
      • [o__o] joined the channel
      • hey janeted, are you around?
      • janeted
        yes
      • sylvainc
        I am searching for the issue brought by my last changes in 1322,
      • you said the tasks view went wrong?
      • janeted
        it just pushed down the task display in the center
      • sylvainc
        you mean the task title went down compared to the thumbnail?
      • janeted
        yes
      • <h3>
      • Translate
      • Subtitles into
      • French
      • </h3>
      • sylvainc
        ok, thanks, I was not sure
      • so janeted, I think I fixed this bad css in 1322, and did items 1. and 2. in 1233
      • do you see anything that should go in them?
      • janeted
        yes the tasks display is fine now
      • and yes 1 and 2 are fine
      • 3 5 and 6 I think can be skipped
      • 4 is now it ticket 1456 - which is probably the next most important thing, as I can visualize on-demand teams deciding to re-organize and then losing track of their in-progress tasks
      • sylvainc
        so shall we keep 1322 and 1323 stable so that ben can review them?
      • Ok for 1456
      • janeted
        yes - I think so
      • and if he's not around in another hour or so - maybe just get them onto staging anyway? so that can do final testing with the extra data that's on there
      • sylvainc
        ok
      • janeted
        so for 1456 - it's just not changing the existing tasks when it's a same-team move (project to project)
      • sylvainc
        yes, I can see the issue here, that's why the original moving function (not done by me) we not doing anything if trying to move inside a team
      • deaner has quit
      • deaner joined the channel
      • deaner has quit
      • deaner joined the channel
      • janeted
        sylvainc, do you want to go ahead and to the merge of 1322, 1323
      • deaner has quit
      • deaner joined the channel
      • deaner has quit
      • deanrjansen joined the channel
      • deanrjansen has quit
      • deaner joined the channel
      • deaner has quit
      • deaner joined the channel
      • deaner has quit
      • deaner joined the channel
      • deaner has quit
      • deaner joined the channel
      • Deaner1 joined the channel
      • Deaner1 has quit
      • Deaner1 joined the channel
      • Deaner1 has quit
      • sylvainc
        ok janeted
      • janeted: ok, merged!
      • janeted
        ah thanks
      • ehazlett, can you deploy staging please?
      • nigel_bot has quit
      • nigel_bot joined the channel
      • ehazlett
        janeted: yes