#elixir-lang

I can’t solve the problem with inserting a new record using Ecto (Phoenix). It does not make any sense. One syntax works, another doesn not. https://gist.github.com/hipertracker/483d7d89e6...

hipertracker: you mean Repo.insert!(%Bible{...}) works, but Repo.insert(changeset) doesn't? I think the first writes directly to adapter, whereas the 2nd runs validations; you're not passing in `year` which is a required field into your changeset

wojtekmach: not exactly. this works Repo.insert! %Bible{code: "bg3", name: "BG3", language_id: language.id}

but that does not:

language = Repo.one(Language)

params = %{code: "bg5", name: "BG5", language_id: language.id, info: "some", year: "1975"}

changeset = Bible.changeset(%Bible{}, params)

Repo.insert!(changeset)

** (Postgrex.Error) ERROR (not_null_violation): null value in column "language_id" violates not-null constraint

I am loosing my language_id value for unknown reason

hipertracker: double-check if it's in @required_ or @optional_fields in your changeset

but, I added those required fields. first syntax works and assign null for them. the second does not work at all because my language_id is alway null. but changeset has params: %{"code" => "bg5", "info" => "some", "language_id" => 49,

"name" => "BG5", "year" => "1975"}

so, it’s all there

and it’s gone after insert!

I mentioned it, because I didn't see langauage_id in required/optional fields in your gist. weird, not sure what's wrong

hipertracker: can you show the updated code?

ericmj: what code?

of the code in the gist

I have a second gist. The problem is with changeset and my foreign key. It’s always null in SQL https://gist.github.com/hipertracker/4044faa960...

hipertracker: can you show the code you changed?

Repo.insert! Map.merge(%Bible{}, params) works perfect, but Repo.insert!(Bible.changeset(%Bible{}, params)) does not work

02:10 <hipertracker> but, I added those required fields.

^ you didnt add those fields in the gist above

It is in the second gist

no, the changeset code

oh, you misunderstand

it uses :code, :name, :year, :sort, :info, :available, :preselected

all parameters you want to change should be in required or optional fields

otherwise ecto ignores them

that's bitten me more than once

But it does not ignore if I use Repo.insert!(Map.merge(%Bible{}, params)) it only nulify my language_id constrain when I use that syntax Repo.insert!(Bible.changeset(%Bible{}, params))

why the first works, and the second does not?

it always insersts all fields

ok, but in the second case it destroy my language_id value. and I have not null there, so it can;t be null

hipertracker: I think what Eric is asking is for you to update your original gist (which includes your schema/changeset definiton and how you're using it) - this way it should be easier to try to help out

wojtekmach: but what should I change? I can see nothing to improve there.

you have to lists of optional and required fields

add the fields you want include in your changeset to either of those lists

ericmj: no, I use them. have a look at the second gist. it uses the same models. this time i added all fields iex(3)> params = %{code: "bg5", name: "BG5", language_id: language.id, info: "some", year: "1975", sort: 0, available: false, preselected: true}

%{available: false, code: "bg5", info: "some", language_id: 49, name: "BG5",

search your code for @required_fields and @optional_fields

add the fields you want included when store things in the database to one of those lists

ericmj: I do not have any more code. I included all required fields.

hipertracker: you need to update this line if you haven't already: https://gist.github.com/hipertracker/483d7d89e6...; this is what we were telling you about. if you already updated it and are still getting errors, then it's weird

literally search your code for “@required_fields” and add language_id on that line

not sure how i can explain it any other way

I am still getting the error

I do not have any more code. just that models and iex

okay, then can you show the code you changed?

hipertracker: https://gist.github.com/hipertracker/483d7d89e6...

I did not change anything in the model definition. All what is diffent is just iex commands

that’s @required_fields

you do not have language_id on that line

add it to that line

ericmj: added

hmm, now works. so changeset is so sensitive?

yes, otherwise your users can insert whatever they want to the database

someone can add a parameter admin=true when updating your user profile

because Repo.insert!(Map.merge(%Bible{}, params)) works even if required fields has no that field. should I avoid such syntax and use always changeset instead?